[US-4.4 / OBT-207] Render one badge per platform - #17
Open
Conversation
Show an individual badge for each entry in the app's platforms array on the dashboard app cards, the Manage Apps grid, and the app detail page, instead of a single combined label. Centralize the platform display labels in constants/platforms and drop the old platformLabel switch in AppCard.
1 task
These pr-us-*.md files are local PR notes that were bundled into the feature commit by mistake; they should never have been tracked/pushed. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
Local decision notes bundled into the feature commit by mistake; never meant to be tracked/pushed. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: QUIET Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
US-4.4 / OBT-207 — Show one platform badge per platform for each app so users can tell at a glance which platforms an app targets, replacing the single combined label.
Changes
src/constants/platforms.ts— single source of truth for platform options and display labels (platformLabel).PlatformMultiSelectnow consumesPLATFORM_OPTIONSfrom here.dashboard/AppCard.tsx: render one<Badge>per entry inapp.platforms; removed the oldplatformLabel()switch that converted a single combined value.AppsPage.tsx: the app grid renders one badge per platform (wraps on multiple).AppDetailPage.tsx: the detail header renders one badge per platform.Badges render correctly for apps with 1, 2, or 3 platforms.
Type of Change
Testing
npm run typecheck— passnpm run lint— 0 errors (pre-existing ProjectsPage warning only)npm run build— pass